Fix ErrorProne 2.39.0 TooManyParameters warning in UploadService #4293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build failure introduced by the ErrorProne upgrade to 2.39.0 in PR #4288.
Issue
ErrorProne 2.39.0 introduced a new
TooManyParameterscheck that flags methods with more than 5 parameters as a warning. Since the build uses-Werror(warnings as errors), this caused the compilation to fail:Solution
Added
@SuppressWarnings("TooManyParameters")annotation to theuploadFile()method inUploadServicethat has 9 parameters. This follows the existing pattern in the codebase for suppressing specific ErrorProne warnings (e.g., inBytecodeUtil).Verification
TooManyParameterswarnings found in the codebaseThis is a minimal fix that allows the ErrorProne 2.39.0 upgrade to proceed without breaking the build or requiring architectural changes to the existing API.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.